PHPC-2343: Require PHP 8.1 #1631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
requested review from
GromNaN and
jmikola
and removed request for
GromNaN
alcaeus
force-pushed
the
phpc-2343-require-php-8.1
branch
from
a1cd411 to
488bc9c
Compare
alcaeus
commented
Sep 5, 2024
| @@ -60,24 +60,6 @@ ZEND_TSRMLS_CACHE_EXTERN() | |||
|
|
|||
| zend_object_handlers* phongo_get_std_object_handlers(void); | |||
|
|
|||
| #define PHONGO_CE_FINAL(ce) \ | |||
There was a problem hiding this comment.
This macro was unused for a while.
| #else | ||
| #define PHONGO_CE_DISABLE_SERIALIZATION(ce) \ | ||
| do { \ | ||
| ce->ce_flags |= ZEND_ACC_NOT_SERIALIZABLE; \ |
There was a problem hiding this comment.
I was able to replace this macro with a non-serializable annotation in the stub files 🎉
| @@ -65,31 +65,6 @@ | |||
| #define PHONGO_BREAK_INTENTIONALLY_MISSING | |||
| #endif | |||
|
|
|||
| #if PHP_VERSION_ID >= 80000 | |||
There was a problem hiding this comment.
I've replaced all these macros with their underlying symbols
jmikola
approved these changes
Sep 5, 2024
alcaeus
force-pushed
the
phpc-2343-require-php-8.1
branch
from
488bc9c to
e15c1a2
Compare
GromNaN
approved these changes
Sep 6, 2024
| @@ -7,6 +7,7 @@ | |||
|
|
|||
| namespace MongoDB\Driver; | |||
|
|
|||
| /** @not-serializable */ | |||
There was a problem hiding this comment.
Is this new? Which software understand this attribute? If found this RFC that would introduce an attribute for that.
There was a problem hiding this comment.
This is used by the gen_stub tool to add the ZEND_ACC_NOT_SERIALIZABLE flag to the class definition: https://github.com/php/php-src/blob/2f3224ea4105c3bebb7db0bee0a57e62dc560a66/build/gen_stub.php#L3472..L3474
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
alcaeus
added a commit
that referenced
this pull request
Oct 15, 2024
* v1.x: PHPC-2460: Use zend_zval_type_name instead of internal macros (#1714) PHPC-2464: Emit deprecation notice for negative "limit" Query option (#1710) PHPC-2458: Deprecate float arg for UTCDateTime constructor (#1695) Document how to run part of the test suite (#1690) Bump version to 1.21-dev (#1661) Update branch names for GHA workflows (#1646) PHPC-2343: Require PHP 8.1 (#1631)
alcaeus
added a commit
that referenced
this pull request
Oct 17, 2024
* v1.x: PHPC-2460: Use zend_zval_type_name instead of internal macros (#1714) PHPC-2464: Emit deprecation notice for negative "limit" Query option (#1710) PHPC-2458: Deprecate float arg for UTCDateTime constructor (#1695) Document how to run part of the test suite (#1690) Bump version to 1.21-dev (#1661) Update branch names for GHA workflows (#1646) PHPC-2343: Require PHP 8.1 (#1631)
alcaeus
added a commit
that referenced
this pull request
Oct 29, 2024
* v1.x: PHPC-1247: Update links to PHP.net docs (#1735) PHPC-2460: Use zend_zval_type_name instead of internal macros (#1714) PHPC-2464: Emit deprecation notice for negative "limit" Query option (#1710) PHPC-2458: Deprecate float arg for UTCDateTime constructor (#1695) Document how to run part of the test suite (#1690) Bump version to 1.21-dev (#1661) Update branch names for GHA workflows (#1646) PHPC-2343: Require PHP 8.1 (#1631)
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Mar 2, 2025
1.21.0 What's Changed * PHPC-2343: Require PHP 8.1 by @alcaeus in mongodb/mongo-php-driver#1631 * Update branch names for GHA workflows by @alcaeus in mongodb/mongo-php-driver#1646 * Bump version to 1.21-dev by @alcaeus in mongodb/mongo-php-driver#1661 * Document how to run part of the test suite by @GromNaN in mongodb/mongo-php-driver#1690 * PHPC-2458: Deprecate float arg for UTCDateTime constructor by @jmikola in mongodb/mongo-php-driver#1695 * PHPC-2464: Emit deprecation notice for negative "limit" Query option by @jmikola in mongodb/mongo-php-driver#1710 * PHPC-2460: Use zend_zval_type_name instead of internal macros by @jmikola in mongodb/mongo-php-driver#1714 * PHPC-1247: Update links to PHP.net docs by @jmikola in mongodb/mongo-php-driver#1735 * Test PPC and Zseries on RHEL 9 by @alcaeus in mongodb/mongo-php-driver#1740 * PHPC-2472: Update to libmongocrypt 1.12.0 by @jmikola in mongodb/mongo-php-driver#1743 * PHPC-2473: Bump to libmongoc 1.29.0 by @jmikola in mongodb/mongo-php-driver#1748 * PHPC-2471: Sync BSON corpus tests for Y10K date parsing by @jmikola in mongodb/mongo-php-driver#1742 * Use correct arch name in Windows artifacts. by @mickverm in mongodb/mongo-php-driver#1762 * PHPC-2499: Update to libmongoc 1.29.2 by @jmikola in mongodb/mongo-php-driver#1766 * PHPC-2496: WriteException stub should inherit ServerException by @jmikola in mongodb/mongo-php-driver#1769 * PHPC-2477: Remove unused libmongoc and libbson constants by @jmikola in mongodb/mongo-php-driver#1768 * PHPC-2502: Remove XFAIL in server-executeQuery-012.phpt by @jmikola in mongodb/mongo-php-driver#1772 * PHPC-2489: Deprecate passing WriteConcern and ReadPreference objects to execute methods by @jmikola in mongodb/mongo-php-driver#1770 * PHPC-2501: Conditionally define MONGOC_CYRUS_PLUGIN_PATH_PREFIX on Windows by @jmikola in mongodb/mongo-php-driver#1777 * PHPC-2503: Conditionally allow more concise output for libbson 1.30 by @jmikola in mongodb/mongo-php-driver#1779 * PHPC:2498: Accept integer types for Document array access by @jmikola in mongodb/mongo-php-driver#1781 * PHPC-2508 and PHPC-2506: Bump libmongoc to 1.30 by @jmikola in mongodb/mongo-php-driver#1785 * PHPC-2513: Check for returned _id before appending insert by @jmikola in mongodb/mongo-php-driver#1788 * PHPC-2519: Bump libmongoc to 1.30.1 by @jmikola in mongodb/mongo-php-driver#1792 * PHPC-2518: Support sort option for updateOne and replaceOne by @jmikola in mongodb/mongo-php-driver#1794 * Use pre-packaged-source for pie downloads by @asgrim in mongodb/mongo-php-driver#1782 New Contributors * @asgrim made their first contribution in mongodb/mongo-php-driver#1782
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPC-2343
Best viewed commit by commit, as this removes a lot of compatibility logic necessary for older PHP versions.